From a961baf9ed6deda242549fe6c014ae22ff1ff8fc Mon Sep 17 00:00:00 2001 From: Sabe Jones Date: Mon, 16 Jan 2017 19:23:04 +0000 Subject: [PATCH] refactor(vehicles): speedup Don't check subtypes if we already know it's a creature. --- lib/cardlib.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/cardlib.py b/lib/cardlib.py index 56fe6e4..dbc7ca8 100644 --- a/lib/cardlib.py +++ b/lib/cardlib.py @@ -171,10 +171,10 @@ def fields_check_valid(fields): for idx, value in fields[field_types]: if 'creature' in value: iscreature = True - if fields.get(field_subtypes): - for idx, value in fields[field_subtypes]: - if 'vehicle' in value: - iscreature = True + elif fields.get(field_subtypes): + for idx, value in fields[field_subtypes]: + if 'vehicle' in value: + iscreature = True if iscreature: return field_pt in fields else: