From 7c5d3f449dc539feb663363c0cc9497e8fd5621e Mon Sep 17 00:00:00 2001 From: Ash Keel Date: Thu, 16 Sep 2021 17:10:46 +0200 Subject: [PATCH] Make some functional components pure --- frontend/src/ui/components/Modal.tsx | 4 +++- frontend/src/ui/components/PageList.tsx | 4 +++- frontend/src/ui/components/TabbedView.tsx | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/frontend/src/ui/components/Modal.tsx b/frontend/src/ui/components/Modal.tsx index 59f7249..383aa05 100644 --- a/frontend/src/ui/components/Modal.tsx +++ b/frontend/src/ui/components/Modal.tsx @@ -14,7 +14,7 @@ export interface ModalProps { bgDismiss?: boolean; } -export default function Modal({ +function Modal({ active, title, onClose, @@ -67,3 +67,5 @@ export default function Modal({ ); } + +export default React.memo(Modal); diff --git a/frontend/src/ui/components/PageList.tsx b/frontend/src/ui/components/PageList.tsx index 933d4e2..c877868 100644 --- a/frontend/src/ui/components/PageList.tsx +++ b/frontend/src/ui/components/PageList.tsx @@ -9,7 +9,7 @@ export interface PageListProps { onPageChange: (page: number) => void; } -export default function PageList({ +function PageList({ current, max, min, @@ -116,3 +116,5 @@ export default function PageList({ ); } + +export default React.memo(PageList); diff --git a/frontend/src/ui/components/TabbedView.tsx b/frontend/src/ui/components/TabbedView.tsx index 194bfe7..c821ad9 100644 --- a/frontend/src/ui/components/TabbedView.tsx +++ b/frontend/src/ui/components/TabbedView.tsx @@ -10,7 +10,7 @@ export interface TabbedViewProps { tabs: TabItem[]; } -export default function TabbedView({ +function TabbedView({ tabs, children, }: React.PropsWithChildren): React.ReactElement { @@ -36,3 +36,5 @@ export default function TabbedView({ ); } + +export default React.memo(TabbedView);