mcg/mlpcardgame
2
0
Fork 0
Code Issues 23 Pull requests 1 Releases Wiki Activity

Fix rename messages assuming having joined
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details

Browse source
This commit is contained in:
Hamcha 2019-10-15 14:36:29 +02:00
parent 3a5989ea0d
commit 07d5e9b2ba
Signed by: hamcha
GPG key ID: 44AD3571EB09A39E
1 changed files with 14 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/network/Client.ts
View file

@ -29,16 +29,21 @@ export abstract class Client extends EventEmitter {
this.metadata.name = data.newname; this.metadata.name = data.newname;
} }
let idx = this.players.indexOf(data.oldname); // Only mutate player list if we have one
if (idx < 0) { // This is because rename messages can be received during the initial
// Weird // handshake, to signal a forced name change before joining.
console.warn( if (this.players) {
`Someone (${data.oldname}) changed name but wasn't on the player list` let idx = this.players.indexOf(data.oldname);
); if (idx < 0) {
this.players.push(data.newname); // Weird
break; console.warn(
`Someone (${data.oldname}) changed name but wasn't on the player list`
);
this.players.push(data.newname);
break;
}
Vue.set(this.players, idx, data.newname);
} }
Vue.set(this.players, idx, data.newname);
this.emit("rename", data.oldname, data.newname); this.emit("rename", data.oldname, data.newname);
break; break;
// A new player joined the room (this includes us) // A new player joined the room (this includes us)