mcg
/
mlpcardgame
2
0
Fork 0
Code Issues 23 Pull Requests 1 Releases Wiki Activity

Basic draft library #19

Merged
hamcha merged 13 commits from feature/draft-lib into master 2019-09-16 13:53:07 +00:00
Conversation 1 Commits 13 Files Changed 15 +915 -9
hamcha commented 2019-09-11 16:01:12 +00:00
Owner
Copy Link

Most of the code will be ported from mcg/draft, but there will be some paradigm shift (since TypeScript has generators but doesn't have channels), plus some niceties since server and client code are shared.

What's needed?

  • Providers that output random cards from specific card pools
  • Slots with alternates (slot that can contain SR/UR instead of C)
  • Cube support
  • Parsing cube .txt
  • I8PCube support
  • Parsing I8PCube .json files
  • Draft session management (doesn't have to use the same protocol as mcg/draft)
  • Bots to fill draft slots

Tests

  • Set provider tests
  • Booster pack generation tests
  • Cube tests
  • I8PCube tests
  • Session tests

Aiming for decent test coverage, but for testing to begins the Deck Builder must be merged first!

Most of the code will be ported from mcg/draft, but there will be some paradigm shift (since TypeScript has generators but doesn't have channels), plus some niceties since server and client code are shared. ## What's needed? - [x] Providers that output random cards from specific card pools - [x] Slots with alternates (slot that can contain SR/UR instead of C) - [x] Cube support - [x] Parsing cube .txt - [x] I8PCube support - [x] Parsing I8PCube .json files - [x] Draft session management (doesn't have to use the same protocol as mcg/draft) - [x] Bots to fill draft slots #### Tests - [x] Set provider tests - [x] Booster pack generation tests - [x] Cube tests - [x] I8PCube tests - [x] Session tests Aiming for decent test coverage, but for testing to begins the Deck Builder must be merged first!
hamcha added a new dependency 2019-09-11 16:01:48 +00:00
#12 Add basic deck builder
hamcha added the
feature
limited
 labels 2019-09-11 16:02:11 +00:00
hamcha commented 2019-09-11 16:02:59 +00:00
Author
Owner
Copy Link

Coverage info: https://artifacts.fromouter.space/mcg/pr-19/coverage/lcov-report/index.html

Coverage info: https://artifacts.fromouter.space/mcg/pr-19/coverage/lcov-report/index.html
hamcha changed title from WIP: Basic draft library to Basic draft library 2019-09-16 13:52:38 +00:00
hamcha closed this pull request 2019-09-16 13:53:07 +00:00
hamcha deleted branch feature/draft-lib 2019-09-16 14:51:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
board

this issue is related to the game board

  
bug

Something is not working

  
code quality

This issue regards code quality

  
deck builder

Deck builder related tickets

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
good first issue

If you're looking to contribute, try this

  
help wanted

Need some help

  
invalid

Something is wrong

  
limited

Related to limited deck building, such as drafts

  
lobby

This issue is related to the lobby

  
low priority

   
network

Related to networking

  
question

More information is needed

  
rule engine

Rule engine related tickets

  
tooling

This issue regards tooling and/or infrastructure

  
wontfix

This won't be fixed

No Label
board
bug
code quality
deck builder
duplicate
feature
good first issue
help wanted
invalid
limited
lobby
low priority
network
question
rule engine
tooling
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#12 Add basic deck builder
mcg/mlpcardgame
Reference: mcg/mlpcardgame#19
No description provided.
Delete Branch "feature/draft-lib"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?