silverweed/rntviewer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

better handling of feature flags

Browse source
This commit is contained in:
silverweed 2025-01-27 13:05:35 +01:00
parent 2d5d46c331
commit 45edfd13a7
2 changed files with 12 additions and 6 deletions

17
src/hover.cpp
View file

@ -790,6 +790,15 @@ struct Sec_Hover_Fn {
});
}
void feature_flags()
{
// NOTE: currently there are no feature flags defined.
u64 flags;
do {
field_le<u64>("Flags: 0x%" PRIX64, &flags);
} while (flags >> 63);
}
// ==============================================================
// TOP-LEVEL SECTIONS
// ==============================================================
@ -965,9 +974,7 @@ struct Sec_Hover_Fn {
range("Compressed payload", section.range.len - section.post_size - ROOTZIP_RANGE_LEN);
} else {
envelope_preamble();
// NOTE: flags in principle require a more complex handling, but for now they are unused,
// so they're always occupying only 8 bytes.
field_le<u64>("Flags: 0x%" PRIX64);
feature_flags();
field_str8<u32>("Name: %s");
field_str8<u32>("Description: %s");
field_str8<u32>("ROOT version: %s");
@ -988,9 +995,7 @@ struct Sec_Hover_Fn {
range("Payload", section.range.len - section.post_size - ROOTZIP_RANGE_LEN);
} else {
envelope_preamble();
// TODO: flags in principle require a more complex handling, but for now they are unused,
// so they're always occupying only 8 bytes.
field_le<u64>("Flags: 0x%" PRIX64);
feature_flags();
field_le<u64>("Header checksum: 0x%" PRIX64);
frame<Frame_Record>("Schema Extension", [this] {
schema_description("Schema Extension");

1
src/mainloop.cpp
View file

@ -160,6 +160,7 @@ void run_main_loop(GLFWwindow *window, Arena *arena, App_State &app)
// Check if the inspected file changed
{
// TODO: this should re-run get_tfile_data and get_rntuple_data!
char buf[sizeof(inotify_event) + NAME_MAX + 1];
ssize_t nbytes = read(app.inspected_file.inot, buf, sizeof(buf));
if (nbytes)