mcg/mlpcardgame
2
0
Fork 0
Code Issues 23 Pull requests 1 Releases Wiki Activity

Basic networking #9

Merged
hamcha merged 17 commits from feature/basic-networking into master 2019-09-06 12:36:11 +00:00
Conversation 0 Commits 17 Files changed 23 +1070 -91
hamcha commented 2019-09-06 09:29:38 +00:00
Owner
Copy link

Solves #4

What's missing

Network protocol

  • Generic chatting

Server

  • Chat message handling
  • Players leaving

Client

  • Events for player joining/leaving/etc
  • Chat events
  • API for leaving rooms
  • API for sending chat messages
  • Join password-protected servers

Tests

  • Client handling of join/part
  • Local client tests
  • Chat messages

General code quality

  • Squash commits to a sane amount
Solves #4 ## What's missing #### Network protocol - [x] Generic chatting #### Server - [x] Chat message handling - [x] Players leaving #### Client - [x] Events for player joining/leaving/etc - [x] Chat events - [x] API for leaving rooms - [x] API for sending chat messages - [x] Join password-protected servers #### Tests - [x] Client handling of join/part - [x] Local client tests - [x] Chat messages #### General code quality - [x] Squash commits to a sane amount
hamcha added the
feature
network
 labels 2019-09-06 09:29:48 +00:00
hamcha added this to the Basic multiplayer build [Cotton Candy] milestone 2019-09-06 09:29:50 +00:00
hamcha self-assigned this 2019-09-06 09:29:52 +00:00
hamcha changed title from WIP: Basic networking to Basic networking 2019-09-06 12:34:19 +00:00
hamcha closed this pull request 2019-09-06 12:36:11 +00:00
hamcha deleted branch feature/basic-networking 2019-09-06 12:37:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
board

this issue is related to the game board

  
bug

Something is not working

  
code quality

This issue regards code quality

  
deck builder

Deck builder related tickets

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
good first issue

If you're looking to contribute, try this

  
help wanted

Need some help

  
invalid

Something is wrong

  
limited

Related to limited deck building, such as drafts

  
lobby

This issue is related to the lobby

  
low priority

   
network

Related to networking

  
question

More information is needed

  
rule engine

Rule engine related tickets

  
tooling

This issue regards tooling and/or infrastructure

  
wontfix

This won't be fixed

No labels
board
bug
code quality
deck builder
duplicate
feature
good first issue
help wanted
invalid
limited
lobby
low priority
network
question
rule engine
tooling
wontfix
Milestone
Clear milestone
No items
No milestone
Basic multiplayer build [Cotton Candy]
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
hamcha
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: mcg/mlpcardgame#9
No description provided.
Delete branch "feature/basic-networking"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?